Preston_PLB
/
oauth2
forked from Mirrors/oauth2
1
0
Fork 0
Code Pull Requests Activity

all: remove redundant type conversion 

Change-Id: I4de1d39f8b72cd1116c56fb00b224a60de035f9e
GitHub-Last-Rev: 4e40ee8059
GitHub-Pull-Request: golang/oauth2#586
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/428982
Reviewed-by: Cody Oss <codyoss@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
This commit is contained in:
cui fliter 2022-09-07 13:18:28 +00:00 committed by Gopher Robot
parent 0ebed06d00
commit f21342109b
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
google/jwt_test.go
View File

@ -73,7 +73,7 @@ func TestJWTAccessTokenSourceFromJSON(t *testing.T) {
t.Fatalf("base64 DecodeString: %v\nString: %q", err, parts[0]) t.Fatalf("base64 DecodeString: %v\nString: %q", err, parts[0])
} }
var hdr jws.Header var hdr jws.Header
if err := json.Unmarshal([]byte(hdrJSON), &hdr); err != nil { if err := json.Unmarshal(hdrJSON, &hdr); err != nil {
t.Fatalf("json.Unmarshal: %v (%q)", err, hdrJSON) t.Fatalf("json.Unmarshal: %v (%q)", err, hdrJSON)
} }
@ -129,7 +129,7 @@ func TestJWTAccessTokenSourceWithScope(t *testing.T) {
t.Fatalf("base64 DecodeString: %v\nString: %q", err, parts[0]) t.Fatalf("base64 DecodeString: %v\nString: %q", err, parts[0])
} }
var hdr jws.Header var hdr jws.Header
if err := json.Unmarshal([]byte(hdrJSON), &hdr); err != nil { if err := json.Unmarshal(hdrJSON, &hdr); err != nil {
t.Fatalf("json.Unmarshal: %v (%q)", err, hdrJSON) t.Fatalf("json.Unmarshal: %v (%q)", err, hdrJSON)
} }

2
jira/jira.go
View File

@ -105,7 +105,7 @@ func (js jwtSource) Token() (*oauth2.Token, error) {
if err != nil { if err != nil {
return nil, err return nil, err
} }
v.Set("assertion", string(assertion)) v.Set("assertion", assertion)
// Fetch access token from auth server // Fetch access token from auth server
hc := oauth2.NewClient(js.ctx, nil) hc := oauth2.NewClient(js.ctx, nil)

2
jws/jws.go
View File

@ -178,5 +178,5 @@ func Verify(token string, key *rsa.PublicKey) error {
h := sha256.New() h := sha256.New()
h.Write([]byte(signedContent)) h.Write([]byte(signedContent))
return rsa.VerifyPKCS1v15(key, crypto.SHA256, h.Sum(nil), []byte(signatureString)) return rsa.VerifyPKCS1v15(key, crypto.SHA256, h.Sum(nil), signatureString)
} }