From 6513477b5bc23d2bbcda8c180f59d236706b219a Mon Sep 17 00:00:00 2001 From: Patrick Jones Date: Tue, 27 Oct 2020 11:58:39 -0700 Subject: [PATCH] oauth2/google: fixed comment formatting and clarified naming --- google/internal/externalaccount/clientauth.go | 4 +--- google/internal/externalaccount/err.go | 2 +- google/internal/externalaccount/err_test.go | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/google/internal/externalaccount/clientauth.go b/google/internal/externalaccount/clientauth.go index 1a5b7fd..ab2b175 100644 --- a/google/internal/externalaccount/clientauth.go +++ b/google/internal/externalaccount/clientauth.go @@ -9,7 +9,7 @@ import ( // ClientAuthentication represents an OAuth client ID and secret and the mechanism for passing these credentials as stated in rfc6749#2.3.1. type ClientAuthentication struct { - //AuthStyle can be either basic or request-body + // AuthStyle can be either basic or request-body AuthStyle oauth2.AuthStyle ClientID string ClientSecret string @@ -34,6 +34,4 @@ func (c *ClientAuthentication) InjectAuthentication(values url.Values, headers h values.Set("client_id", c.ClientID) values.Set("client_secret", c.ClientSecret) } - - return } diff --git a/google/internal/externalaccount/err.go b/google/internal/externalaccount/err.go index 5366cd0..a31ca95 100644 --- a/google/internal/externalaccount/err.go +++ b/google/internal/externalaccount/err.go @@ -2,7 +2,7 @@ package externalaccount import "fmt" -//Error for handling OAuth related error responses as stated in rfc6749#5.2. +// Error for handling OAuth related error responses as stated in rfc6749#5.2. type Error struct { Code string URI string diff --git a/google/internal/externalaccount/err_test.go b/google/internal/externalaccount/err_test.go index 6ceb0c9..b121b7c 100644 --- a/google/internal/externalaccount/err_test.go +++ b/google/internal/externalaccount/err_test.go @@ -2,7 +2,7 @@ package externalaccount import "testing" -func TestError_Generator(t *testing.T) { +func TestError(t *testing.T) { e := Error{ "42", "http:thisIsAPlaceholder",