Preston_PLB
/
kernel-aes67
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
kernel-aes67/drivers/gnss
History
Francesco Dolcini fed99212ac treewide, serdev: change receive_buf() return type to size_t 
receive_buf() is called from ttyport_receive_buf() that expects values
">= 0" from serdev_controller_receive_buf(), change its return type from
ssize_t to size_t.

The need for this clean-up was noticed while fixing a warning, see
commit 94d0539425 ("Bluetooth: btnxpuart: fix recv_buf() return value").
Changing the callback prototype to return an unsigned seems the best way
to document the API and ensure that is properly used.

GNSS drivers implementation of serdev receive_buf() callback return
directly the return value of gnss_insert_raw(). gnss_insert_raw()
returns a signed int, however this is not an issue since the value
returned is always positive, because of the kfifo_in() implementation.
gnss_insert_raw() could be changed to return also an unsigned, however
this is not implemented here as request by the GNSS maintainer Johan
Hovold.

Suggested-by: Jiri Slaby <jirislaby@kernel.org>
Link: https://lore.kernel.org/all/087be419-ec6b-47ad-851a-5e1e3ea5cfcc@kernel.org/
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> #for-iio
Reviewed-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Alex Elder <elder@linaro.org>
Acked-by: Maximilian Luz <luzmaximilian@gmail.com>  # for platform/surface
Acked-by: Lee Jones <lee@kernel.org>
Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20240122180551.34429-1-francesco@dolcini.it
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 		2024-01-27 18:13:53 -08:00
..
Kconfig gnss: add USB support 2021-12-22 15:36:39 +01:00
Makefile gnss: add USB support 2021-12-22 15:36:39 +01:00
core.c driver core: class: remove module * from class_create() 2023-03-17 15:16:33 +01:00
mtk.c
…
serial.c treewide, serdev: change receive_buf() return type to size_t 2024-01-27 18:13:53 -08:00
serial.h
…
sirf.c treewide, serdev: change receive_buf() return type to size_t 2024-01-27 18:13:53 -08:00
ubx.c gnss: ubx: add support for the reset gpio 2023-12-15 09:29:54 +01:00
usb.c gnss: usb: add support for Sierra Wireless XM1210 2021-12-22 15:38:12 +01:00