Preston_PLB
/
kernel-aes67
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

thermal: ti-bandgap: Convert to platform remove callback returning void 

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Uwe Kleine-König 2023-09-27 21:37:35 +02:00 committed by Rafael J. Wysocki
parent f021f05262
commit f3e38da002
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/thermal/ti-soc-thermal/ti-bandgap.c
View File

@ -1069,7 +1069,7 @@ free_irqs:
} }
static static
int ti_bandgap_remove(struct platform_device *pdev) void ti_bandgap_remove(struct platform_device *pdev)
{ {
struct ti_bandgap *bgp = platform_get_drvdata(pdev); struct ti_bandgap *bgp = platform_get_drvdata(pdev);
int i; int i;
@ -1098,8 +1098,6 @@ int ti_bandgap_remove(struct platform_device *pdev)
if (TI_BANDGAP_HAS(bgp, TSHUT)) if (TI_BANDGAP_HAS(bgp, TSHUT))
free_irq(gpiod_to_irq(bgp->tshut_gpiod), NULL); free_irq(gpiod_to_irq(bgp->tshut_gpiod), NULL);
return 0;
} }
#ifdef CONFIG_PM_SLEEP #ifdef CONFIG_PM_SLEEP
@ -1283,7 +1281,7 @@ MODULE_DEVICE_TABLE(of, of_ti_bandgap_match);
static struct platform_driver ti_bandgap_sensor_driver = { static struct platform_driver ti_bandgap_sensor_driver = {
.probe = ti_bandgap_probe, .probe = ti_bandgap_probe,
.remove = ti_bandgap_remove, .remove_new = ti_bandgap_remove,
.driver = { .driver = {
.name = "ti-soc-thermal", .name = "ti-soc-thermal",
.pm = DEV_PM_OPS, .pm = DEV_PM_OPS,