Preston_PLB
/
kernel-aes67
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

crypto: hisilicon/sec2 - fix some cleanup issues 

This patch fixes following cleanup issues:
 - The return value of the function is
   inconsistent with the actual return type.
 - After the pointer type is directly converted
   to the `__le64` type, the program may crash
   or produce unexpected results.

Signed-off-by: Qi Tao <taoqi10@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Qi Tao 2024-01-26 17:38:27 +08:00 committed by Herbert Xu
parent c4af422545
commit dd1a502cab
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/crypto/hisilicon/sec2/sec_crypto.c
View File

@ -118,7 +118,7 @@ struct sec_aead {
}; };
/* Get an en/de-cipher queue cyclically to balance load over queues of TFM */ /* Get an en/de-cipher queue cyclically to balance load over queues of TFM */
static inline int sec_alloc_queue_id(struct sec_ctx *ctx, struct sec_req *req) static inline u32 sec_alloc_queue_id(struct sec_ctx *ctx, struct sec_req *req)
{ {
if (req->c_req.encrypt) if (req->c_req.encrypt)
return (u32)atomic_inc_return(&ctx->enc_qcyclic) % return (u32)atomic_inc_return(&ctx->enc_qcyclic) %
@ -1371,7 +1371,7 @@ static int sec_skcipher_bd_fill_v3(struct sec_ctx *ctx, struct sec_req *req)
sec_sqe3->bd_param = cpu_to_le32(bd_param); sec_sqe3->bd_param = cpu_to_le32(bd_param);
sec_sqe3->c_len_ivin |= cpu_to_le32(c_req->c_len); sec_sqe3->c_len_ivin |= cpu_to_le32(c_req->c_len);
sec_sqe3->tag = cpu_to_le64(req); sec_sqe3->tag = cpu_to_le64((unsigned long)req);
return 0; return 0;
} }