Preston_PLB/kernel-aes67
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

EDAC/dmc520: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/20231004131254.2673842-8-u.kleine-koenig@pengutronix.de
This commit is contained in:
Uwe Kleine-König 2023-10-04 15:12:40 +02:00 committed by Borislav Petkov (AMD)
parent 0576ded05b
commit d27cb32e00
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/edac/dmc520_edac.c
View File

@ -602,7 +602,7 @@ err:
return ret; return ret;
} }
static int dmc520_edac_remove(struct platform_device *pdev) static void dmc520_edac_remove(struct platform_device *pdev)
{ {
u32 reg_val, idx, irq_mask_all = 0; u32 reg_val, idx, irq_mask_all = 0;
struct mem_ctl_info *mci; struct mem_ctl_info *mci;
@ -626,8 +626,6 @@ static int dmc520_edac_remove(struct platform_device *pdev)
edac_mc_del_mc(&pdev->dev); edac_mc_del_mc(&pdev->dev);
edac_mc_free(mci); edac_mc_free(mci);
return 0;
} }
static const struct of_device_id dmc520_edac_driver_id[] = { static const struct of_device_id dmc520_edac_driver_id[] = {
@ -644,7 +642,7 @@ static struct platform_driver dmc520_edac_driver = {
}, },
.probe = dmc520_edac_probe, .probe = dmc520_edac_probe,
.remove = dmc520_edac_remove .remove_new = dmc520_edac_remove
}; };
module_platform_driver(dmc520_edac_driver); module_platform_driver(dmc520_edac_driver);