Preston_PLB
/
kernel-aes67
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fpga: xilinx-pr-decoupler: Convert to platform remove callback returning void 

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/3e37e7cf91749fbaba67619f4ffc6a9a7352a671.1703006638.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Xu Yilun <yilun.xu@linux.intel.com>
This commit is contained in:
Uwe Kleine-König 2023-12-19 18:32:10 +01:00 committed by Xu Yilun
parent 24bf6f4be4
commit a584df3031
No known key found for this signature in database
GPG Key ID: FCB70381A4A08CDA
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/fpga/xilinx-pr-decoupler.c
View File

@ -150,7 +150,7 @@ err_clk:
return err; return err;
} }
static int xlnx_pr_decoupler_remove(struct platform_device *pdev) static void xlnx_pr_decoupler_remove(struct platform_device *pdev)
{ {
struct fpga_bridge *bridge = platform_get_drvdata(pdev); struct fpga_bridge *bridge = platform_get_drvdata(pdev);
struct xlnx_pr_decoupler_data *p = bridge->priv; struct xlnx_pr_decoupler_data *p = bridge->priv;
@ -158,13 +158,11 @@ static int xlnx_pr_decoupler_remove(struct platform_device *pdev)
fpga_bridge_unregister(bridge); fpga_bridge_unregister(bridge);
clk_unprepare(p->clk); clk_unprepare(p->clk);
return 0;
} }
static struct platform_driver xlnx_pr_decoupler_driver = { static struct platform_driver xlnx_pr_decoupler_driver = {
.probe = xlnx_pr_decoupler_probe, .probe = xlnx_pr_decoupler_probe,
.remove = xlnx_pr_decoupler_remove, .remove_new = xlnx_pr_decoupler_remove,
.driver = { .driver = {
.name = "xlnx_pr_decoupler", .name = "xlnx_pr_decoupler",
.of_match_table = xlnx_pr_decoupler_of_match, .of_match_table = xlnx_pr_decoupler_of_match,