Preston_PLB/kernel-aes67
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

memory: omap-gpmc: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Tony Lindgren <tony@atomide.com>
Link: https://lore.kernel.org/r/019d9dc31af9b30a6b675fec219e64b667475efd.1702822744.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
This commit is contained in:
Uwe Kleine-König 2023-12-17 15:29:34 +01:00 committed by Krzysztof Kozlowski
parent 08c1aeaa45
commit 6a4edb1a4f
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/memory/omap-gpmc.c
View File

@ -2690,7 +2690,7 @@ gpio_init_failed:
return rc; return rc;
} }
static int gpmc_remove(struct platform_device *pdev) static void gpmc_remove(struct platform_device *pdev)
{ {
int i; int i;
struct gpmc_device *gpmc = platform_get_drvdata(pdev); struct gpmc_device *gpmc = platform_get_drvdata(pdev);
@ -2702,8 +2702,6 @@ static int gpmc_remove(struct platform_device *pdev)
gpmc_mem_exit(); gpmc_mem_exit();
pm_runtime_put_sync(&pdev->dev); pm_runtime_put_sync(&pdev->dev);
pm_runtime_disable(&pdev->dev); pm_runtime_disable(&pdev->dev);
return 0;
} }
#ifdef CONFIG_PM_SLEEP #ifdef CONFIG_PM_SLEEP
@ -2747,7 +2745,7 @@ MODULE_DEVICE_TABLE(of, gpmc_dt_ids);
static struct platform_driver gpmc_driver = { static struct platform_driver gpmc_driver = {
.probe = gpmc_probe, .probe = gpmc_probe,
.remove = gpmc_remove, .remove_new = gpmc_remove,
.driver = { .driver = {
.name = DEVICE_NAME, .name = DEVICE_NAME,
.of_match_table = of_match_ptr(gpmc_dt_ids), .of_match_table = of_match_ptr(gpmc_dt_ids),