mtd: maps: sa1100-flash: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Acked-by: Tudor Ambarus <tudor.ambarus@linaro.org> Link: https://lore.kernel.org/linux-mtd/20231008200143.196369-17-u.kleine-koenig@pengutronix.de
This commit is contained in:
parent
a105291c90
commit
553cc00f3e
@ -285,19 +285,17 @@ static int sa1100_mtd_probe(struct platform_device *pdev)
|
||||
return err;
|
||||
}
|
||||
|
||||
static int sa1100_mtd_remove(struct platform_device *pdev)
|
||||
static void sa1100_mtd_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct sa_info *info = platform_get_drvdata(pdev);
|
||||
struct flash_platform_data *plat = dev_get_platdata(&pdev->dev);
|
||||
|
||||
sa1100_destroy(info, plat);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static struct platform_driver sa1100_mtd_driver = {
|
||||
.probe = sa1100_mtd_probe,
|
||||
.remove = sa1100_mtd_remove,
|
||||
.remove_new = sa1100_mtd_remove,
|
||||
.driver = {
|
||||
.name = "sa1100-mtd",
|
||||
},
|
||||
|
Loading…
Reference in New Issue
Block a user