From 51cbbcd6469b2a32e222ec220039af20a16f2769 Mon Sep 17 00:00:00 2001 From: Liang He Date: Wed, 15 Jun 2022 20:51:05 +0800 Subject: [PATCH] w1: Add missing of_node_put() in w1.c In __w1_attach_slave_device, we really need not to use of_node_put in normal path as the reference is escaped by sl. However, we need of_node_put in the fail path before put_device. Signed-off-by: Liang He Link: https://lore.kernel.org/r/20220615125105.3966317-1-windhl@126.com [krzysztof: fix whitespace / checkpatch] Signed-off-by: Krzysztof Kozlowski --- drivers/w1/w1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index bc11cdd2e4f2..e16a60872226 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -692,6 +692,7 @@ static int __w1_attach_slave_device(struct w1_slave *sl) dev_err(&sl->dev, "Device registration [%s] failed. err=%d\n", dev_name(&sl->dev), err); + of_node_put(sl->dev.of_node); put_device(&sl->dev); return err; }