Preston_PLB
/
kernel-aes67
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hwmon: (pmbus/ucd9000) Increase delay from 250 to 500us 

Following the failure observed with a delay of 250us, experiments were
conducted with various delays. It was found that a delay of 350us
effectively mitigated the issue.

To provide a more optimal solution while still allowing a margin for
stability, the delay is being adjusted to 500us.

Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com>
Link: https://lore.kernel.org/r/20240507194603.1305750-1-lakshmiy@us.ibm.com
Fixes: 8d655e6523 ("hwmon: (ucd90320) Add minimum delay between bus accesses")
Reviewed-by: Eddie James <eajames@linux.ibm.com>
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Lakshmi Yadlapati 2024-05-07 14:46:03 -05:00 committed by Guenter Roeck
parent d02abd57e7
commit 26e8383b11
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/hwmon/pmbus/ucd9000.c
View File

@ -80,11 +80,11 @@ struct ucd9000_debugfs_entry {
* It has been observed that the UCD90320 randomly fails register access when * It has been observed that the UCD90320 randomly fails register access when
* doing another access right on the back of a register write. To mitigate this * doing another access right on the back of a register write. To mitigate this
* make sure that there is a minimum delay between a write access and the * make sure that there is a minimum delay between a write access and the
* following access. The 250us is based on experimental data. At a delay of * following access. The 500 is based on experimental data. At a delay of
* 200us the issue seems to go away. Add a bit of extra margin to allow for * 350us the issue seems to go away. Add a bit of extra margin to allow for
* system to system differences. * system to system differences.
*/ */
#define UCD90320_WAIT_DELAY_US 250 #define UCD90320_WAIT_DELAY_US 500
static inline void ucd90320_wait(const struct ucd9000_data *data) static inline void ucd90320_wait(const struct ucd9000_data *data)
{ {