Commit Graph

35732 Commits

Author SHA1 Message Date
Andrey Volk 7f3a833466 [mod_commands] Fix leaking session readlock in uuid_capture_text 2023-04-14 14:48:41 +03:00
Jakub Karolczyk eec1fd737c [mod_signalwire] Make this module working with libks and signalwire-c in versions 2.0
* [mod_signalwire] Fix load credentials data from json

* [mod_signalwire] Fix parsing of configuration response
2023-04-13 16:24:35 +03:00
Andrey Volk 4d3b0a5778 [mod_opus] Fix buf scope in switch_opus_decode(). 2023-04-10 15:10:17 +03:00
Andrey Volk be3a73af62
Merge pull request #2032 from signalwire/coverity_06042023_mod_xml_rpc
[mod_xml_rpc] Coverity CID 1294469 (Resource leak)
2023-04-07 09:30:07 +03:00
Jakub Karolczyk 9994c51499 [mod_xml_rpc] Coverity CID 1294469 (Resource leak) 2023-04-06 22:31:50 +01:00
Andrey Volk 919647a035
Merge pull request #2033 from signalwire/coverity_06042023_mod_xml_scgi
[mod_xml_scgi] Coverity CID 1468595 (Resource leak)
2023-04-07 00:21:16 +03:00
Andrey Volk daeaceb27c
Merge pull request #2031 from signalwire/coverity_06042023_mod_xml_curl
[mod_xml_curl] Coverity CID 1468413 (Resource leak)
2023-04-07 00:19:41 +03:00
Andrey Volk ce5194a523
Merge pull request #2030 from signalwire/coverity_06042023_mod_verto
[mod_verto] Coverity CID 1320754 (Resource leak)
2023-04-07 00:16:41 +03:00
Andrey Volk d4faa1ddd2
Merge pull request #2029 from signalwire/coverity_06042023_mod_java
[mod_java] Coverity CID 1320753 (Resource leak)
2023-04-07 00:14:52 +03:00
Andrey Volk 87dea6c503
Merge pull request #2028 from signalwire/coverity_06042023_mod_imagick
[mod_imagick] Coverity CID 1500258 (Resource leak)
2023-04-07 00:13:17 +03:00
Andrey Volk 0091a90ea8
Merge pull request #2027 from signalwire/coverity_06042023_mod_event_multicast
[mod_event_multicast] Coverity CID 1468504 (Resource leak)
2023-04-07 00:11:41 +03:00
Andrey Volk f5bd2c653d
Merge pull request #2026 from signalwire/coverity_06042023_mod_dialplan_asterisk
[mod_dialplan_asterisk] Coverity CID 1214207 (Resource leak)
2023-04-07 00:07:19 +03:00
Andrey Volk 814348c739
Merge pull request #2025 from signalwire/coverity_06042023_mod_av
[mod_av] Coverity CID 1500320 (Resource leak)
2023-04-07 00:05:40 +03:00
Andrey Volk 1acab416ad
Merge pull request #2024 from signalwire/coverity_06042023_mod_amqp
[mod_amqp] Coverity CID 1468426 (Resource leak)
2023-04-07 00:03:54 +03:00
Jakub Karolczyk 11b9c1d104 [mod_event_multicast] Coverity CID 1468504 (Resource leak) 2023-04-06 18:36:34 +01:00
Jakub Karolczyk a8f6625d12 [mod_amqp] Coverity CID 1468426 (Resource leak) 2023-04-06 18:31:40 +01:00
Jakub Karolczyk 5388319dd3 [mod_xml_curl] Coverity CID 1468413 (Resource leak) 2023-04-06 18:27:42 +01:00
Jakub Karolczyk 875a1b04ff [mod_av] Coverity CID 1500320 (Resource leak) 2023-04-06 18:25:56 +01:00
Jakub Karolczyk 99e26d3448 [mod_dialplan_asterisk] Coverity CID 1214207 (Resource leak) 2023-04-06 18:25:11 +01:00
Jakub Karolczyk a9e81ae0b8 [mod_verto] Coverity CID 1320754 (Resource leak) 2023-04-06 18:24:26 +01:00
Jakub Karolczyk 0e9954467f [mod_imagick] Coverity CID 1500258 (Resource leak) 2023-04-06 18:23:33 +01:00
Jakub Karolczyk b02fbc702d [mod_java] Coverity CID 1320753 (Resource leak) 2023-04-06 18:21:40 +01:00
Jakub Karolczyk 80d5790274 [mod_xml_scgi] Coverity CID 1468595 (Resource leak) 2023-04-06 18:20:07 +01:00
Dragos Oancea 73ea37c5ab
[Core] Coverity fixes
* [core] coverity CID 1320751 (Dereference before null check)

* [core] coverity CID 1294546 (Unchecked return value)

* [core] coverity CID 1227661 (Logically dead code)

* [core] coverity CID 1227656 (Logically dead code)

* [core] coverity CID 1060948 (Explicit null dereferenced)

* [core] coverity CID 1346465 (Unchecked return value)

* [core] coverity CID 1364953 (Logically dead code)

* [core] coverity CID 1468210 (Dereference before null check)

* [core] coverity CID 1468546 (Dereference before null check)

* [core] coverity CID 1468342 (Dereference before null check)
2023-04-05 18:54:11 +03:00
Jakub Karolczyk 49c1c35982
[core] Coverity fixes
* [core] Coverity CID 1468218 (Resource leak)

* [core] Coverity CID 1468214 (Resource leak)

* [core] Coverity CID 1294472 (Resource leak)

* [core] Coverity CID 1294470 (Resource leak)

* [core] Coverity CID 1500361 (Resource leak)

* [core] Coverity CID 1500308 (Resource leak)

* [core] Coverity CID 1500278 (Resource leak)

---------

Co-authored-by: Andrey Volk <andywolk@gmail.com>
2023-04-01 00:07:59 +03:00
Andrey Volk 04dd67da00
Merge pull request #2016 from signalwire/count
[Core] Remove unused count variable from switch_core_session_execute_exten()
2023-03-31 23:39:18 +03:00
Andrey Volk 55313696db [Core] Remove unused count variable from switch_core_session_execute_exten() 2023-03-31 22:48:11 +03:00
Andrey Volk d1639199c3
Merge pull request #2014 from signalwire/prototype
[Core] Fix switch_core_sqldb_destroy() function declaration.
2023-03-31 21:00:42 +03:00
Andrey Volk 9940623bce [Core] Fix switch_core_sqldb_destroy() function declaration. 2023-03-31 20:47:56 +03:00
Jakub Karolczyk 9494148b10
[mod_sofia] Coverity fixes
* [mod_sofia] Coverity CID 1468634 (Resource leak)

* [mod_sofia] Coverity CID 1294467 (Resource leak)

---------

Co-authored-by: Andrey Volk <andywolk@gmail.com>
2023-03-30 22:00:40 +03:00
Andrey Volk c540af16ad
Merge pull request #2011 from signalwire/coverity_24032023_mod_pgsql
[mod_pgsql] Coverity CID 1468401 (Resource leak)
2023-03-30 19:59:44 +03:00
Jakub Karolczyk 65b24c65db [mod_pgsql] Coverity CID 1468401 (Resource leak) 2023-03-29 23:26:35 +01:00
Andrey Volk f5f7f76cd4
Merge pull request #2006 from dragos-oancea/mod_amr-cov
[mod_amr] coverity CID 1395603 (Unsigned compared against 0)
2023-03-29 19:19:47 +03:00
Dragos Oancea 3d547647b2
[mod_verto] Coverity fixes
* [mod_verto] coverity CID (Logically dead code)

* [mod_verto] coverity CID 1468609 (Logically dead code)
2023-03-29 19:14:54 +03:00
Andrey Volk 16884775b9
Merge pull request #2005 from dragos-oancea/mod_opus-cov
[mod_opus] coverity CID 1320733 (Result is not floating-point)
2023-03-29 19:12:19 +03:00
Dragos Oancea 48b8b0c4d7
[Core] Coverity fixes
* [core] coverity CID 1395504 (Logically dead code)

* [core] coverity CID 1395581 (Dereference before null check)

* [core] coverity CID 1346451 (Improper use of negative value)

* [core] coverity CID 1395497 (Dereference before null check)

* [core] coverity CID 1468458 (Dereference before null check)
2023-03-29 19:08:18 +03:00
Andrey Volk 8e5dc5a087 [mod_opusfile] Fix missing rdlock unlock in switch_opusfile_open() 2023-03-29 19:05:18 +03:00
Dragos Oancea 3c1824a685 [mod_amr] coverity CID 1395603 (Unsigned compared against 0) 2023-03-29 17:20:04 +03:00
Dragos Oancea 3c4695ea31 [mod_opus] coverity CID 1320733 (Result is not floating-point) 2023-03-29 17:18:57 +03:00
Andrey Volk e479f1b648
Merge pull request #1639 from signalwire/docker
[Documentation] Fix typo in README.md
2023-03-28 17:39:41 +03:00
Tomasz Ostrowski afc8d78a18
[mod_enum] Fix use-after-free if creating resolver from file failed 2023-03-28 17:36:01 +03:00
Andrey Volk 6c97e3b0f4 [Core] Fix missing mutex unlock in switch_ivr_dmachine_ping() 2023-03-28 17:10:25 +03:00
Andrey Volk 02c25a24a4
Merge pull request #1765 from greenbea/patch-14
[mod_say_en] change epoch to 64 bit int
2023-03-28 17:06:58 +03:00
Andrey Volk ef9268ec0c
Merge pull request #1900 from jyelloz/master
[mod_ladspa] Added activate/deactivate support.
2023-03-28 17:00:28 +03:00
Henrique bb2fa44071
[mod_conference] handle personal canvas with vmuted member 2023-03-28 16:53:16 +03:00
yois615 6d65f8e08c
[mod_callcenter] Fix stale agents and UUID broadcasts
* [call_center] Stop uuid_broadcast on answer

* [mod_callcenter] Fix stale members in database

When a channel is originated to an agent but the
member fails to bridge to that agent, the database is
not updated with the member status and a stale entry
of 'Answered' persists until mod_callcenter is restarted.

Additionally, cc_agent_found is set before the bridge,
therefore ending the while loop on the member channel.
If there is a problem with the agent bridge, the call is
terminated prematurely.

In this commit, we:

* Move the SQL update of the member
to the 'Answered' state to the agent thread instead of
the member's thread, so that correct data is populated.

* Reset the members state accordingly to Abandoned or
Waiting if the channels fail to bridge.

* Use cc_agent_bridged to end the member loop,
so that a member is put back on queue if the agent
channel fails to bridge.
2023-03-28 14:53:16 +03:00
yois615 965e88a6b0
[core, mod_cidlookup] Free memory allocated via strdup
In mod_cidlookup and several other modules, config parameters
are read from external XML files using the SWITCH_CONFIG_ITEM_STRING_STRDUP
method.  These items do not have string_options, and are not freed
with switch_xml_config_cleanup.  We therefore need to call switch_safe_free
for config without string_options.  We also add switch_xml_config_cleanup
to mod_cidlookup.  There are other modules that may be affected but this
commit makes no attempt at fixing those.

Fixes #1752
2023-03-28 01:47:23 +03:00
Andrey Volk f680a29405
Merge pull request #1413 from yois615/master
[mod_sofia] Randomize OPTIONS Ping interval
2023-03-28 01:43:35 +03:00
Tomasz Ostrowski 8e604e8a94
[mod_event_multicast] Few fixes
* [mod_event_multicast] Fix crash / invalid pointer dereference

* [mod_event_multicast] Check current number of addresses before zeroing memory on init

* [mod_event_multicast] Fix condition checking number of addresses on init

* [mod_event_multicast] Fix addresses zeroing on init

* [mod_event_multicast] Reorder memset and assert after malloc
2023-03-27 20:23:07 +03:00
Andrey Volk 2c36dcdd50
Merge pull request #1843 from greenbea/patch-17
[mod_commands] Fix and improve coalesce function
2023-03-27 20:03:40 +03:00