Preston_PLB
/
bubbletea
forked from Mirrors/bubbletea
1
0
Fork 0
Code Pull Requests Activity

Re-render all lines if the total number of lines increases 

If the number of lines increased there's a chance that the increase in
lines caused the terminal to scroll (even in the altscreen). Because of
this we must repaint everything, as skipping lines will mis-render.

Thanks to @fiws for reporting this bug.
This commit is contained in:
Christian Rocha 2021-05-14 19:53:22 -04:00
parent 54da5489a0
commit 70be13948a
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
standard_renderer.go
View File

@ -114,7 +114,14 @@ func (r *standardRenderer) flush() {
// 2. The new line is the same as the old line, in which case we // 2. The new line is the same as the old line, in which case we
// can skip rendering for this line as a performance optimization. // can skip rendering for this line as a performance optimization.
_, ignoreLine := r.ignoreLines[i] _, ignoreLine := r.ignoreLines[i]
if ignoreLine || (len(newLines) > i && len(oldLines) > i && newLines[i] == oldLines[i]) {
if ignoreLine ||
// Number of lines did not increase
(len(newLines) <= len(oldLines) &&
// Indexes available for lookup (guard against panics)
len(newLines) > i && len(oldLines) > i &&
// Lines are identical
(newLines[i] == oldLines[i])) {
skipLines[i] = struct{}{} skipLines[i] = struct{}{}
} else { } else {
clearLine(out) clearLine(out)
@ -163,7 +170,7 @@ func (r *standardRenderer) flush() {
_, _ = io.WriteString(out, line) _, _ = io.WriteString(out, line)
if i != len(newLines)-1 { if i < len(newLines)-1 {
_, _ = io.WriteString(out, "\r\n") _, _ = io.WriteString(out, "\r\n")
} }
} }