From 65cb46c47595dcdadac1d2b28a486c42ea72c200 Mon Sep 17 00:00:00 2001 From: Christian Rocha Date: Thu, 25 Feb 2021 12:10:36 -0500 Subject: [PATCH] Remove notes about how we'd auto-truncate lines as we're doing that now --- renderer.go | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/renderer.go b/renderer.go index 4a3263b..f422670 100644 --- a/renderer.go +++ b/renderer.go @@ -96,23 +96,6 @@ func (r *renderer) flush() { return } - // We have an opportunity here to limit the rendering to the terminal width - // and height, but this would mean a few things: - // - // 1) We'd need to maintain the terminal dimensions internally and listen - // for window size changes. [done] - // - // 2) We'd need to measure the width of lines, accounting for multi-cell - // rune widths, commonly found in Chinese, Japanese, Korean, emojis and so - // on. We'd use something like go-runewidth - // (http://github.com/mattn/go-runewidth). - // - // 3) We'd need to measure the width of lines excluding ANSI escape - // sequences and break lines in the right places accordingly. - // - // Because of the way this would complicate the renderer, this may not be - // the place to do that. - out := new(bytes.Buffer) // Clear any lines we painted in the last render.