From 608fde59edde447d4f34ce7e8ddc8bb3d54b80fa Mon Sep 17 00:00:00 2001 From: Christian Stewart Date: Mon, 3 Jan 2022 23:33:28 -0800 Subject: [PATCH] fix(tea): allocate msgs channel in constructor Race condition bug: Start() is called in a new gorotuine, then Send(). If the Send happens before the msgs channel is allocated, the message is dropped. Instead allocate the channel in the constructor, so msgs is never nil. Signed-off-by: Christian Stewart --- tea.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tea.go b/tea.go index 7c9b901..fdf29ee 100644 --- a/tea.go +++ b/tea.go @@ -239,6 +239,7 @@ func NewProgram(model Model, opts ...ProgramOption) *Program { initialModel: model, output: os.Stdout, input: os.Stdin, + msgs: make(chan Msg), CatchPanics: true, } @@ -252,8 +253,6 @@ func NewProgram(model Model, opts ...ProgramOption) *Program { // StartReturningModel initializes the program. Returns the final model. func (p *Program) StartReturningModel() (Model, error) { - p.msgs = make(chan Msg) - var ( cmds = make(chan Cmd) errs = make(chan error) @@ -554,9 +553,7 @@ func (p *Program) Start() error { // This method is currently provisional. The method signature may alter // slightly, or it may be removed in a future version of this package. func (p *Program) Send(msg Msg) { - if p.msgs != nil { - p.msgs <- msg - } + p.msgs <- msg } // Quit is a convenience function for quitting Bubble Tea programs. Use it